svn commit: r457878 - head/textproc/rubygem-liquid-tag-parser

[Sunpoet Po-Chuan Hsieh]

On Tue, Jan 2, 2018 at 11:54 PM, Mathieu Arnold <mat at freebsd.org> wrote:

> Le 02/01/2018 à 16:33, Sunpoet Po-Chuan Hsieh a écrit :
> > Author: sunpoet
> > Date: Tue Jan  2 15:33:33 2018
> > New Revision: 457878
> > URL: https://svnweb.freebsd.org/changeset/ports/457878
> >
> > Log:
> >   Fix build on Ruby prior to 2.5
> >
> >   Ruby 2.5 bundled RDoc 6.0.1. Due to unknown RDoc issue, RDoc prior to
> >   6.0.0.beta1+ failed to parse the regex in lib/liquid/tag/parser.rb.
> >   Upstream also set "has_rdoc = false" in gemspec.
> >
> > Modified:
> >   head/textproc/rubygem-liquid-tag-parser/Makefile
> >
> > Modified: head/textproc/rubygem-liquid-tag-parser/Makefile
> > ============================================================
> ==================
> > --- head/textproc/rubygem-liquid-tag-parser/Makefile  Tue Jan  2
> 15:33:28 2018        (r457877)
> > +++ head/textproc/rubygem-liquid-tag-parser/Makefile  Tue Jan  2
> 15:33:33 2018        (r457878)
> > @@ -18,4 +18,6 @@ NO_ARCH=    yes
> >  USE_RUBY=    yes
> >  USES=                gem
> >
> > +NOPORTDOCS=  yes
> > +
>
>
> Setting NOPORTDOCS in a port was never supported, it is a deprecated
> variable, set only in make.conf, please revert. If you need to disable
> the DOCS option, either do not add it to OPTIONS_DEFINE, or add it to
> OPTIONS_EXCLUDE.
>
>
It's a temporary fix to avoid the rdoc issue.

from Mk/Uses/gem.mk:
.if ${PORT_OPTIONS:MDOCS}
RUBYGEM_ARGS+=  --rdoc --ri
.else
RUBYGEM_ARGS+=  --no-rdoc --no-ri
.endif

I did think of OPTIONS_EXCLUDE but did not know it works 'cos it looks
strange when there's no OPTIONS_DEFINE=DOCS.
But anyway it really works.
Thanks!


>
> --
> Mathieu Arnold
>
>
>