svn commit: r487403 - head/databases/puppetdb-cli

[Mathieu Arnold]

On Thu, Dec 13, 2018 at 09:02:25PM -1000, Romain Tartière wrote:
> On Fri, Dec 14, 2018 at 06:19:50AM +0100, Jan Beich wrote:
> > Romain Tartière <romain at FreeBSD.org> writes:
> > 
> > > +BROKEN_SSL_REASON_libressl=	Needs an old version of OpenSSL (older than 1.1)
> > 
> > Does it build fine with DEFAULT_VERSIONS+=libressl-devel ?
> 
> Of course not, good catch!  Probably the same for openssl-devel but it
> seems absent as of today, so I don't know if we should add it.
> 
> > > +.include <bsd.port.pre.mk>
> > 
> > .include <bsd.port.options.mk> would have been enough.
> 
> Yes, it seems to be okay too.  I was following
> https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#dads-after-port-mk
> 
> > > +.if ${OSVERSION} >= 1200085
> > 
> > Checking OSVERSION without OPSYS is illegal. DragonFly has OSVERSION=9999999
> > with LibreSSL 2.4.4 in base.
> > 
> > https://github.com/DragonFlyBSD/DPorts/blob/f18014a15a13/Mk/bsd.port.mk#L1184
> > https://github.com/DragonFlyBSD/DragonFlyBSD/blob/bd84e83893b2/crypto/libressl/README.DRAGONFLY
> 
> Fixed!
> 
> > > +BROKEN_SSL+=	base
> > 
> > BROKEN_SSL=base is *not supported* by USES=ssl, and BROKEN_SSL cannot set
> > after bsd.port.pre.mk because USES=ssl was already processed by that time.
> 
> D'oh!  Maybe this information may have it's place in the Porter's Handbook:
> https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#uses-ssl

No, the fact that it is not supported is a bug, but as nobody ever said
it was not working, I only discovered it last week or something.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181214/baa7219e/attachment.sig>