svn commit: r477695 - in head/graphics: . libheif

[Mathieu Arnold]

On Tue, Aug 21, 2018 at 10:16:09AM -0700, Yuri wrote:
> On 8/20/18 5:24 PM, Kurt Jaeger wrote:
> > +BROKEN_FreeBSD_10=	encoder_fuzzer.cc:84:5: error: use of undeclared identifier 'free'
> 
> 
> This is most likely wrong. 'free' is available everywhere. The likely reason
> is a missing #include <stdlib.h> somewhere.
> 
> 
> > +LIB_DEPENDS=		libde265.so:multimedia/libde265
> > +LIB_DEPENDS+=		libx265.so:multimedia/x265
> > +LIB_DEPENDS+=		libpng16.so:graphics/png
> 
> 
> These are usually defined without repeating LIB_DEPENDS+=.
> 
> 
> > +USES=			autoreconf libtool pkgconfig shared-mime-info \
> > +			shebangfix
> > +USE_GITHUB=		yes
> > +GH_ACCOUNT=		strukturag
> > +GH_PROJECT=		libheif
> > +
> > +GNU_CONFIGURE=		yes
> > +
> > +SHEBANG_GLOB=		*.sh
> > +
> > +USE_LDCONFIG=		yes
> 
> USE_LDCONFIG should definitely be in the USExx section. GNU_CONFIGURE and SHEBANG_GLOB should also probably be in USExx section, because this way Makefile looks more compact.

A section can contain blank lines, it makes it more readable.  So, this
is correct.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180822/2c1c15fe/attachment.sig>