svn commit: r477306 - in head: audio audio/pulseaudio-module-xrdp net/xrdp

[Mathieu Arnold]

On Thu, Aug 16, 2018 at 07:15:58PM +0900, Koichiro Iwao wrote:
> On Thu, Aug 16, 2018 at 11:07:02AM +0200, Mathieu Arnold wrote:
> > On Thu, Aug 16, 2018 at 01:51:04AM +0000, Koichiro Iwao wrote:
> > > +PORTNAME=	pulseaudio-module-xrdp
> > > +PORTVERSION=	0.0.20180808
> > 
> > This is not the way to handle software that do not define versions.
> > Please read this to learn how to handle this in the future:
> > 
> > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex4
> 
> If the upstream really have the version like 0.0.YYYYmmdd, it it OK?

It would be, yes. But I have never seen it.

> BTW, upstream's going to make 1.0.0 release shortly. I'll make an update
> to 1.0.0 rather than correcting it.

You should not "fix" this port, I said "in the future" as in, for other
ports.  To fix this, you would need to add PORTEPOCH and it would be a
waste.


-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180816/1402ac55/attachment.sig>