svn commit: r476670 - in head/devel: . rubygem-solve

[Mathieu Arnold]

On Wed, Aug 08, 2018 at 04:29:29PM -0400, Ryan Steinmetz wrote:
> 
> On (08/08/18 14:17), Adam Weinberger wrote:
> > On Wed, Aug 8, 2018 at 1:53 PM Ryan Steinmetz <zi at freebsd.org> wrote:
> > > +COMMENT=       A ruby version constraint solver
> > > 
> > > 
> > > Added: head/devel/rubygem-solve/pkg-descr
> > > ==============================================================================
> > > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > > +++ head/devel/rubygem-solve/pkg-descr  Wed Aug  8 19:53:06 2018        (r476670)
> > > @@ -0,0 +1,3 @@
> > > +A Ruby version constraint solver.
> > > +
> > > +WWW: https://rubygems.org/gems/solve
> > > 
> > 
> > Ryan,
> > 
> > You've just added a number of ports with uninformative pkg-descrs, and
> > unhelpful COMMENT strings. These aren't merely formalities. Users
> > should be able to read the pkg-descr and understand if it's the right
> > package for them, and COMMENT is the first target for searches.
> > Please, go back over them and, at the very least, expand the pkg-descr
> > files with more information. As a general rule, pkg-descr should NEVER
> > be the same text as the COMMENT.
> 
> Adam,
> 
> These are the description strings from authors of the code.  They came from
> either rubygems.org and/or the gem source repository.  For example, in the
> case of rubygem-solve:
> 
> https://rubygems.org/gems/solve
> 
> https://github.com/berkshelf/solve
> 
> If you have any specific things you would like to see added to any of the
> individual ports, please let me know.

pkg-descr must contain sentences, something that can be read. It must at
least be two lines long, so that it is descriptive enough.  The fact
that upstream is crappy does not mean you can put he same crap in the
ports tree.  It is your job as committer to make sure that ports conform
to our policies and requirements.  If upstream does not provide a better
decription, create one, basd on your knowledge of the software.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180808/fa926e0a/attachment.sig>