svn commit: r476193 - in head/audio/lame: . files

[Mathieu Arnold]

On Thu, Aug 02, 2018 at 03:01:02PM +0200, Alexander Leidinger wrote:
> 
> Quoting Jan Beich <jbeich at freebsd.org> (from Wed, 01 Aug 2018 22:35:49 +0200):
> 
> > Alexander Leidinger <netchild at FreeBSD.org> writes:
> > 
> > > Author: netchild
> > > Date: Wed Aug  1 20:01:27 2018
> > > New Revision: 476193
> > > URL: https://svnweb.freebsd.org/changeset/ports/476193
> > > 
> > > Log:
> > >   Move patents text from the Makefile to a file.
> > >   While I'm here, make it more an explanatory text than just a
> > >   copy&paste from the previous comment of the Makefile.
> > > 
> > >   Requested by:	portmgr (mat)
> > [...]
> > > +LICENSE_FILE_PATENTS=	$(FILESDIR)/lame_patents.txt
> > 
> > $(...) isn't consistent with the rest of the file.
> 
> Ooops.
> 
> > $ portlint -C
> > WARN: Makefile: [18]: use ${VARIABLE}, instead of $(VARIABLE).
> > FATAL: Makefile: LICENSE_NAME_PATENTS appears out-of-order.
> > FATAL: Makefile: LICENSE_FILE_PATENTS appears out-of-order.
> > FATAL: Makefile: order must be LICENSE/LICENSE_COMB/LICENSE_GROUPS(_\w+)?/LICENSE_NAME(_\w+)?/LICENSE_TEXT(_\w+)?/LICENSE_FILE(_\w+)?/LICENSE_PERMS(_\w+)?/LICENSE_DISTFILES(_\w+)?.
> > 3 fatal errors and 1 warning found.
> 
> May I challenge the order? LICENSE shall be ordered alphabetically, and then
> we mix the patent grouped parts... Looks strange to me. If you look at the
> result after your patch, it goes to PATENTS, then LGPL then PATENTS again.
> For me the natural grouping is per license, so first all the variables for
> the first license, then all for the second. Alphabetical order is off course
> easy to implement in tools like portlint, and easy so teach to maintainers,
> but for the Mk files it doesn't matter, and in my opinion we should change
> that to group per license, as it is less context-switching from one license
> to another for the person which looks at multi-license ports.

Thank you for your input.  We already have an existing order, documented
in:

https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-license.html

Please help keep the ports tree coherent by keeping to it.

Kind regards,

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180803/08dbe6ea/attachment.sig>