svn commit: r454177 - head/lang/gcc7
Gerald Pfeifer
gerald at FreeBSD.org
Tue Nov 14 14:05:48 UTC 2017
Author: gerald
Date: Tue Nov 14 14:05:47 2017
New Revision: 454177
URL: https://svnweb.freebsd.org/changeset/ports/454177
Log:
Make sure what we install is stripped (i.e., debug info is removed).
The straightforward way is setting INSTALL_TARGET to install-strip,
which is supported by the upstream GCC build machinery.
Unfortunately this fails when running as regular user (non-root)
since strip requires write permission to the files in question,
and we install binaries as r-xr-xr-x by default. To work around
that we need to set BINMODE to allow for write access by the user,
something that's common on GNU/Linux (which is why this probably
has not been noticed there). This is not necessary when running
as root.
(A different approach suggested was to set STRIP=true, alas that
leads to many files actually not being stripped. This is due to
GCC using its own script install-sh that in turn uses cp, chmod,
strip,... instead of our own install-* tools in many cases.)
According to tests by sobomax@ and me installs of lang/gcc6 went
down by about a fourth.
Reported by: Ports QA Framework, miwi, sobomax
Discussed with: tijl, miwi
Tested by: sobomax
Differential Revision: https://reviews.freebsd.org/D10357
Modified:
head/lang/gcc7/Makefile
Modified: head/lang/gcc7/Makefile
==============================================================================
--- head/lang/gcc7/Makefile Tue Nov 14 13:59:23 2017 (r454176)
+++ head/lang/gcc7/Makefile Tue Nov 14 14:05:47 2017 (r454177)
@@ -3,7 +3,7 @@
PORTNAME= gcc
PORTVERSION= 7.2.0
-PORTREVISION= 3
+PORTREVISION= 4
CATEGORIES= lang
MASTER_SITES= GCC/releases/gcc-${DISTVERSION}
PKGNAMESUFFIX= ${SUFFIX}
@@ -82,6 +82,10 @@ CONFIGURE_ARGS+=--disable-bootstrap
.else
CONFIGURE_ARGS+=--with-build-config=bootstrap-debug
ALL_TARGET= bootstrap-lean
+.endif
+INSTALL_TARGET= install-strip
+.if ${UID} != 0
+BINMODE= 755
.endif
CONFIGURE_ARGS+=--disable-nls \
--enable-gnu-indirect-function \
More information about the svn-ports-all
mailing list