svn commit: r437215 - in head/graphics: gbm libEGL libGL libglapi

[Jan Beich]

Matthew Rezny <rezny at freebsd.org> writes:

> On Wednesday 29 March 2017 19:51:55 Jan Beich wrote:
>
>> Matthew Rezny <rezny at FreeBSD.org> writes:
>> > -	@${REINPLACE_CMD} -e 's|x86_64|amd64|' \
>> > +	@${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[:space:]* //|' \
>> 
>> [:space:] is invalid character class thus treated as a list of characters.
>> \S corresponds to [^[:space:]], while \s to [[:space:]].
>> 
>>   $ man pcrepattern | col -b | fgrep -m1 \\S
>>            \S     any character that is not a white space character
>> 
>> This may break build given -march, etc. are no longer stripped.
>
> I wish that information had been presented when I said "I guess it should have 
> been [:space:] instead of [:graph:] in the replacement." after you stated 
> [:graph:] was plain incorrect, although it is what had been previously 
> suggested to me and did seem to be working.

I didn't focus on pointing out every mistake with the existing hack
because it was soon going away. Now that devel/libclc depends on llvm40
the original motivation to hold out on 17.* (bug 217016) before 2017Q2
has been weakened.

>
> To be sure there is no misunderstanding now, would you consider this correct?
> @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[^[:space:]]* //|' \

Not quite, adding extra space after [] is unnecessary.

  -e 's|\\S\*|[^[:space:]]*|' \