svn commit: r436814 - in head/comms: . direwolf direwolf/files
Diane Bruce
db at db.net
Sat Mar 25 03:28:52 UTC 2017
On Fri, Mar 24, 2017 at 09:28:26PM -0500, Kyle Evans wrote:
> On Fri, Mar 24, 2017 at 8:47 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > It was not explained why the FreeBSD version of Makefile is needed at all.
> > What's wrong with original version? Most of its contents are not related
> > to FreeBSD in any way.
>
> The project Makefile does a basic OS check then includes
> Makefile.{linux,macosx,win}. The linux/macosx makefiles contain enough
> platform specific things that we saw fit to write a FreeBSD version.
> We're doing some work with upstream to get this integrated into
> Direwolf in a manner that's more maintainable by all.
It looked as if upstream simply preferred a separate platform
specific Makefile much as other projects have done in the past;
But after requesting a pull request upstream expressed a preference
for a single Makefile and work was started on this.
>
> I'm attaching a patch that should address your concerns, with
> PORTREVISION bumped due to the dw-start.sh change -- /usr/local was
I note that upstream already have a change we can pull in with
next iteration hence a PORTREVISION will not be necessary.
>
> Thanks,
>
> Kyle Evans
--
- db at FreeBSD.org db at db.net http://www.db.net/~db
More information about the svn-ports-all
mailing list