svn commit: r436814 - in head/comms: . direwolf direwolf/files

Alexey Dokuchaev danfe at FreeBSD.org
Sat Mar 25 02:49:02 UTC 2017


On Fri, Mar 24, 2017 at 09:39:15PM -0500, Kyle Evans wrote:
> On Fri, Mar 24, 2017 at 9:35 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > Thanks, one more little thing before it can be committed.
> 
> Hah, jokes on you, there were two things I messed up! =)

;-)

> >> +MAKE_ENV+=   STAGEDIR=${STAGEDIR}
> >
> > You didn't run make -V MAKE_ARGS, did you? :-)
> 
> Oy, I actually didn't because all of the other directories I cared
> about were in MAKE_ENV, and I was looking for STAGEDIR specifically.
> 
> Attached is a revised patch, s/STAGEDIR/DESTDIR/ and the dw-start.sh
> script was getting installed with the wrong permissions because I
> overlooked the fact it's installed in the examples/ with a bunch of
> datafiles.

LGTM, but I'm sleepy and fainting away.  Let's let Diane to review
and handle it as it was their commit in the first place.

./danfe


More information about the svn-ports-all mailing list