svn commit: r436712 - in head/net/zerotier: . files

[Alexey Dokuchaev]

On Wed, Mar 22, 2017 at 08:57:48PM +0100, Kirill Ponomarev wrote:
> On 03/22, Alexey Dokuchaev wrote:
> > On Wed, Mar 22, 2017 at 06:12:57PM +0000, Kirill Ponomarew wrote:
> > > New Revision: 436712
> > > URL: https://svnweb.freebsd.org/changeset/ports/436712
> > > 
> > > Log:
> > >   Update net/zerotier to 1.2.2
> > >   
> > >   PR:		217838
> > >   Submitted by:	dch at skunkwerks.at
> > >   Approved by:	mat (mentor)
> > > [...]
> > >  
> > > -MAINTAINER=	corsmith at gmail.com
> > > +MAINTAINER=	dch at skunkwerks.at
> > 
> > This part was not reflected in the log.
> 
> This part was reflected in PR.

It should also be reflected in the commit log.

> > > -USES=		gmake
> > > +USES=		gmake compiler:c11
> > 
> > Nor was this one.
>  
> This part is reflected in PR as well.

Ditto.

> > > -OPTIONS_DEFINE=	CONTROLLER
> > > -
> > > -CONTROLLER_DESC=	Network management controller microservice support
> > > -CONTROLLER_USES=	sqlite
> > > -CONTROLLER_MAKE_ARGS=	ZT_ENABLE_NETWORK_CONTROLLER=1
> > 
> > Why this part was removed after I've added it just several days ago in
> > r435612 (see PR 215031)?  If this feature is no longer valid it should
> > have been reflected in the commit log.  Please do not destroy work of
> > others without at least giving a sound reason.
> 
> Feel free to coordinate your work with current (new) maintainer and
> commit needed changes.

Wrong.  Someone (PR 215031) had contributed their work, someone else (me)
reviewed it and committed it.  One just should not in good will step over
and kill it with no explanation.  This kind of attitude and action would
turn away people from making any further contributions and give us pretty
bad looks.

./danfe