svn commit: r436576 - in head/emulators/wine-devel: . files

[Cy Schubert]

In message <20170322051110.GC23308 at FreeBSD.org>, Gleb Smirnoff writes:
> On Tue, Mar 21, 2017 at 10:09:35PM -0700, Cy Schubert wrote:
> C> In message <20170322041508.GA23308 at FreeBSD.org>, Gleb Smirnoff writes:
> C> > On Tue, Mar 21, 2017 at 10:35:39PM +0100, Gerald Pfeifer wrote:
> C> > G> > But without the bump I can't enforce rebuild for FreeBSD 12 users, 
> can I
> C> > ?
> C> > G> 
> C> > G> Well, it did not build for FreeBSD 12 users without your patch, or 
> C> > G> did I misunderstand?
> C> > 
> C> > The version built earlier won't work properly on newer head, so we
> C> > want users to rebuild. I thought bumping PORTREVISION is the right
> C> > thing to do.
> C> 
> C> Generally, if it's broken and the commit fixes the build, no PORTREVISION 
> C> bump is needed.
> C> 
> C> If the ABI in base changes, then a PORTREVISION bump is also required.
> 
> Thanks for explanation. The latter is the case (ABI changed), so bump
> was useful.

Examining the code I saw that. PORTREVISION forces a build. If for whatever 
reason we want to force a a rebuild of a package then we need to bump 
PORTREVISION. If there's any doubt it's better to force a rebuild than not.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.