svn commit: r436576 - in head/emulators/wine-devel: . files

[Gerald Pfeifer]

Hi Gleb,

On Tue, 21 Mar 2017, Gleb Smirnoff wrote:
> Log:
>   Make it compilable on FreeBSD 12 after struct inpcb and struct tcpcb 
>   were stopped being exported.
> Added:
>   head/emulators/wine-devel/files/patch-dlls_iphlpapi_ipstats.c   (contents, props changed)

thanks for creating a fix for this and sharing it.

> +PORTREVISION=	1

This actually isn't necessary and triggers a needless rebuild for
users on older versions of FreeBSD than that.

(When the build is broken under some circumstances, but not others, 
simply fixing it is sufficient.)

This is why (gentle hint) it actually does make sense to working 
with the maintainer of a port instead of just committing a fix. :-)

> Added: head/emulators/wine-devel/files/patch-dlls_iphlpapi_ipstats.c
> ==============================================================================

Have you submitted this upstream as well?  We should minimize local
patches like this, not the least since some people (and my nightly
automated tester, for example) also build from upstream sources.

And it adds maintenance overhead over time.


If you have not submitted it yet, 
  https://wiki.winehq.org/Submitting_Patches
has good information (if a bit much I'll admit) and I'll be happy
to help.

At a minimum, if you don't want to follow the regular process, 
sending it to wine-patches at winehq.com copying me would be good.

Thanks,
Gerald