svn commit: r436241 - in head/comms: . multimon-ng multimon-ng/files

[Kyle Evans]

On Wed, Mar 15, 2017 at 8:18 AM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Wed, Mar 15, 2017 at 01:13:10PM +0000, Diane Bruce wrote:
>> New Revision: 436241
>> URL: https://svnweb.freebsd.org/changeset/ports/436241
>>
>> Log:
>>   multimon-ng a fork of multimon.
>>   It decodes the following digital transmission modes:
>> ...
>> +PLIST_FILES+=        bin/multimon-ng
>
> Why += here?
>
>> +.include <bsd.port.pre.mk>
>> +.if ${PORT_OPTIONS:MX11}
>> +USE_XORG+=   sm ice x11 xext
>> +.endif
>
> Why not use option helpers (esp. since you're already using them above)?

I'm afraid the reasoning for this one is kind of a sad one. I keep
overlooking _USE= when reviewing bsd.options.mk for my options because
of the similarities to _USES=, which actually doesn't seem to be
formally documented at the top like I thought. For some reason it just
doesn't seem as neat to me as the non-options-helper equivalents.

I can submit a patch in a bit to convert that to:

X11_USE= XORG=sm,ice,x11,xext

Apologies,

Kyle Evans