svn commit: r435576 - head/devel/pkgconf

[Mathieu Arnold]

Resending, thunderbird managed to mangle everything up.

Le 08/03/2017 à 12:18, Dag-Erling Smørgrav a écrit :
> Mathieu Arnold <mat at FreeBSD.org> writes:
>> So, before changing this policy, I am going to ask you, as portmgr, to
>> please back the change out.
> Why do I have the feeling that you're doing this purely out of spite?
> Because as it currently stands (after your followup commit), the patch
> has no effect on ports, but greatly facilitates life for developers.

Well, I did not write this out of spite, I waited a long while before asking this, talking with my fellows portmgr, and they feel the same way as I do.


> I think you're forgetting that pkgconf does not exist solely for the use
> of the ports tree, but also for the use of developers who write software
> on FreeBSD.

Your commit message said : "This renders 82.6% of Mk/Uses/pathfix.mk obsolete." Which is the policy change we are against because it was not discussed first.

I have nothing against making the life of developers easier, but this is not the message your commit was conveying. At all. And not at all what Tijl and you talked about afterwards.

Now, instead of plainly reverting your commit, what you could do is add a non default option to pkgconf adding lib/pkgconfig to the search path. But it must be off by default. But you have to[1] do the first one or the second possibility I gave you.

1: rule 5 of https://www.freebsd.org/doc/en/articles/committers-guide/rules.html


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170308/716d2f8a/attachment.sig>