svn commit: r443599 - head/Mk

[Tobias C. Berner]

Hi there


You're right, this only "addressed" the trailing slash issue and not
the one with the symlink, which I forgot about.

I think this should be fixed in qt5-qmake itself and not in the ports framework.

I'll reopen it.



mfg Tobias

On 15 June 2017 at 05:39, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Wed, Jun 14, 2017 at 08:54:33PM -0600, Adam Weinberger wrote:
>> > On 14 Jun, 2017, at 19:56, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
>> > ...
>> > [I] was somewhat disappointed that my PR was closed as WONTFIX (works
>> > as intended) with no response to analysis of the problem, no discussion
>> > of the proposed solution, etc.
>> >
>> > All the effort was flushed down the toilet.
>> >
>> > Needless to say, the problem is still there until someone else trips on
>> > it and opens a similar PR.
>>
>> Consider opening a new PR (199297 turned into a different issue) and
>> attaching a patch.
>
> I might do so, but I'd like to hear from Tobias first regarding the way
> he had handled this one.  Right now I'm a bit hesitant to spend time on
> crafting a patch and filing another PR just to find out it is closed as
> WONTFIX later again.
>
>> And there probably is merit to finding out what other stuff breaks
>> when WRKDIRPREFIX != realpath WRKDIRPREFIX.
>
> Yeah, I mention this; there seems to be low interest though.
>
> ./danfe