svn commit: r442588 - in head/www: nginx nginx-full

[Bryan Drewery]

On 6/6/17 5:39 AM, Alexey Dokuchaev wrote:
> On Mon, Jun 05, 2017 at 05:50:06PM -0600, Adam Weinberger wrote:
>>> On 4 Jun, 2017, at 18:18, Sergey A. Osokin <osa at FreeBSD.org> wrote:
>>>
>>> Hi Bartek and Adam,
>>>
>>> I don't think I can get this, so two questions for you guys:
>>> o) what was the reason to bump PORTREVISION in www/nginx?
>>> o) wouldn't it btter to just bump PORTREVISION in www/nginx-full?
>>
>> Hi Sergey,
> 
> [ Wrapping very long lines ]
> 
>> I'll give Bartek a chance to explain in more detail, but I supported an
>> nginx bump because it was less complex for the future.
>>
>> If nginx-full got a bump, then it would need to be bumped every time
>> nginx got bumped, or nginx would have to be bumped by two and nginx-full's
>> PORTREVISION line gets removed, and then the line has to be removed at the
>> next nginx update or reset. At the end of the day, bumping nginx was more
>> straightforward. It triggers an update for everyone else, but becomes less
>> invasive over the long haul.
> 
> It seems that everyone bumps port revisions whenever they please these days;
> wondering about it just a waste of time.  Just an exampler: r442562, where
> it was bumped for pkg-descr change (sic!) in a port that takes considerable
> time to build. :-(
> 

pkg-descr is part of the generated package. Bumping PORTREVISION in that
commit had a real impact and change.  Plus the actual content change is
not a small spelling change.

> # svn diff -c r442561 ^/
> Index: head/emulators/wine/pkg-descr
> ===================================================================
> --- head/emulators/wine/pkg-descr       (revision 442560)
> +++ head/emulators/wine/pkg-descr       (revision 442561)
> @@ -5,8 +5,12 @@ without the performance or memory usage penalties
>  a similar look and feel to other applications on your desktop.
> 
>  Many applications already work, more or less, including versions of
> -Microsoft Office and several games.
> +Microsoft Office and many games.
> 
> +Use this port for 32-bit Windows binaries in an i386 environment or
> +64-bit Windows binaries in an amd64 environment; use emulators/i386-wine
> +for 32-bit Windows binaries in an amd64 environment.
> +

It's explaining something to users about the proper use of the port and
how to obtain the right package for the right environment.

Yes it hurts to rebuild a port for something like this, but it is
absolutely correct.  Building ports synchronously in your terminal while
waiting for them is the root problem here; building ports asynchronously
in the background with a package builder and not caring when they are
done is the right solution.

It would be nice if the tools and metadata were smart enough to just
reuse the existing package and update the pkg-descr within it.  Until
that time a rebuild is needed.


>  WWW: http://www.winehq.org/
> 
>  Gerald Pfeifer <gerald at FreeBSD.org>





-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170608/0398c055/attachment.sig>