svn commit: r430643 - in head/comms/wsjtx: . files

[John Marino]

On 1/5/2017 10:20, Diane Bruce wrote:
> Author: db
> Date: Thu Jan  5 16:20:21 2017
> New Revision: 430643
> URL: https://svnweb.freebsd.org/changeset/ports/430643
>
> Log:
>   Fix svn properties. Bug in psvn!
>   Mark as broken on i386
>   Note typo with include_directories had no effect on build but fixed anyway
>
> Modified:
>   head/comms/wsjtx/Makefile
>   head/comms/wsjtx/files/patch-CMakeLists.txt   (contents, props changed)
>   head/comms/wsjtx/files/patch-Configuration.cpp
>   head/comms/wsjtx/files/patch-Radio.cpp   (contents, props changed)
>   head/comms/wsjtx/files/patch-WFPalette.hpp   (contents, props changed)
>   head/comms/wsjtx/files/patch-lib_wsprd_Makefile
>   head/comms/wsjtx/files/patch-manpages_CMakeLists.txt   (contents, props changed)
>
> Modified: head/comms/wsjtx/Makefile
> ==============================================================================
> --- head/comms/wsjtx/Makefile	Thu Jan  5 15:32:31 2017	(r430642)
> +++ head/comms/wsjtx/Makefile	Thu Jan  5 16:20:21 2017	(r430643)
> @@ -37,4 +37,7 @@ do-extract:
>  	${TAR} xf ${DISTDIR}/${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} -C${WRKDIR}
>  	${TAR} xf ${WRKDIR}/${PORTNAME}-${PORTVERSION}/src/wsjtx.tgz -C${WRKDIR}
>
> +BROKEN_i386=    does not build on i386 due to openmp
> +
>  .include <bsd.port.mk>
> +
>

Personally, I don't think this was necessary.
devel/openmp has this line:
ONLY_FOR_ARCHS= amd64 # i386

wsjtx would have been "skipped" due to openmp.
Now if openmp suddenly supports i386, wsjtx is marked broken in error.

I would have just left it.  I think Jan's point was that you shouldn't 
put an unconditional dependency on openmp (make it optional), not that 
you should mark the port BROKEN on i386.  You may have misunderstood him 
to begin with.

John






---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus