svn commit: r430641 - in head/comms/wsjtx: . files

Jan Beich jbeich at freebsd.org
Thu Jan 5 15:03:00 UTC 2017


Diane Bruce <db at FreeBSD.org> writes:

> +		libomp.so:devel/openmp

devel/openmp is currently amd64-only, so comms/wsjtx loses i386 support
by unconditionally depending on it.

>  CMAKE_ARGS+=	-DPORT_BUILDING::STRING="ON" \
> -		-DCMAKE_PREFIX_PATH+=${LOCALBASE}/wsjtx/lib
> +		-DCMAKE_PREFIX_PATH+=${LOCALBASE}/wsjtx/lib \
> +		-DLOCALBASE::STRING="${LOCALBASE}"
[...]
> +if (CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
> +  set (FREEBSD TRUE)
> +  link_directories("/usr/lib" "${LOCALBASE}/lib")
> +  include_directories("/usr/lib" "${LOCALBASE}/include")
> +endif()

Why not add USES=localbase:ldflags instead? Besides, -I/usr/lib is bogus
while -L/usr/lib is poisonous for lang/gcc*.

> Modified: head/comms/wsjtx/distinfo
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-CMakeLists.txt
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-Radio.cpp
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-WFPalette.hpp
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-manpages_CMakeLists.txt
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/pkg-plist
> ==============================================================================
> Binary file (source and/or target). No diff available.

Can you fix svn:mime-type of these files?


More information about the svn-ports-all mailing list