svn commit: r433143 - head/editors/emacs-devel

[Joseph Mingrone]

ashish at FreeBSD.org (Ashish SHUKLA) writes:
> On Thu, 2 Feb 2017 12:52:29 +0000 (UTC), Joseph Mingrone <jrm at FreeBSD.org> said:
> | Author: jrm
> | Date: Thu Feb  2 12:52:29 2017
> | New Revision: 433143
> | URL: https://svnweb.freebsd.org/changeset/ports/433143

> | Log:
> |   editors/emacs-devel: Update to latest commit on master branch

> |   Approved by:	ashish (maintainer, implicit), swills (mentor, implicit)

> Hi Joseph,

> Thanks for the update, although I didn't approve this diff.

> The implicit approval you sought[1] was for PORTREVISION bump, and this commit
> is not that.

> References:
> [1]  https://reviews.freebsd.org/D9287#192339

> Thanks!

Hello Ashish,

My apologies!  This indeed wasn't what we had agreed upon.  I somehow had it in my mind that the implicit approval was for updating to a newer upstream commit.  Hopefully this will teach me not to do such things in a rush with many other things going on at the same time.

This commit was in the spirit on what I had in mind.  That is, get newer code out regularly in the -devel port, so users can test early and often.  Would such a commit, that only modifies the GH_TAGNAME, EMACS_REV, and the distfile also be acceptable for implicit approval?

Again, sorry for breaking our agreement.  It was due to careless and not intentional.

Joseph
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 930 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170202/0e6ebac1/attachment.sig>