svn commit: r457507 - head/science/lamprop

Alexey Dokuchaev danfe at FreeBSD.org
Fri Dec 29 14:35:23 UTC 2017


On Fri, Dec 29, 2017 at 02:25:16PM +0000, Luca Pizzamiglio wrote:
> New Revision: 457507
> URL: https://svnweb.freebsd.org/changeset/ports/457507
> 
> Log:
>   science/lamprop: Update to 3.4
>   
>   PR:		221544
>   Submitted by:	rsmith at xs4all.nl (maintainer)
> 
> Modified: head/science/lamprop/Makefile
> ...
> +PORTVERSION=	3.4
> +CATEGORIES=	science python
> +MASTER_SITES=	GH

What is the point of setting MASTER_SITES now that it was converted to
USE_GITHUB?

>  do-install:
> -	cd ${WRKSRC} && ${MAKE} PREFIX=${STAGEDIR}${PREFIX} install
> +	${INSTALL_SCRIPT} ${WRKSRC}/lamprop ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_MAN} ${WRKSRC}/doc/lamprop.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
> +	${INSTALL_MAN} ${WRKSRC}/doc/lamprop.5 ${STAGEDIR}${MAN5PREFIX}/man/man5

Since maintainer is apparently also the author, could they be convinced to
provide appropriate `install' target so we don't have to define `do-install'
one in the port?

./danfe


More information about the svn-ports-all mailing list