svn commit: r456900 - in head: devel/pire net-p2p/bitcoin-daemon net-p2p/bitcoin-utils security/p5-Net-SinFP

[Alexey Dokuchaev]

On Fri, Dec 22, 2017 at 06:04:01PM +0000, Alexey Dokuchaev wrote:
> On Fri, Dec 22, 2017 at 06:46:08PM +0100, Jan Beich wrote:
> > Jan Beich <jbeich at FreeBSD.org> writes:
> > > Mark Linimon <linimon at FreeBSD.org> writes:
> > >> New Revision: 456900
> > >> URL: https://svnweb.freebsd.org/changeset/ports/456900
> > >>
> > >> Log:
> > >>   Use a more modern way of distinguishing "big-endian platforms".
> > >>   
> > >>   This will attempt builds on arm platforms on the cluster.
> > >> ...
> > >> Modified: head/devel/pire/Makefile
> > >>  
> > >> +NOT_FOR_ARCHS=		powerpc powerpc64 sparc64
> > >> +NOT_FOR_ARCHS_REASON=	does not support big-endian architectures
> > >> +
> > >>  USE_GITHUB=	yes
> > >>  GH_ACCOUNT=	dprokoptsev
> > >>  
> > >> @@ -21,8 +24,5 @@ INSTALL_TARGET=	install-strip
> > >>  USES=		autoreconf bison libtool
> > >>  USE_LDCONFIG=	yes
> > >>  TEST_TARGET=	check
> > >> -
> > >> -ONLY_FOR_ARCHS=		amd64 i386
> > >> -ONLY_FOR_ARCHS_REASON=	not yet ported to big-endian platforms
> > > [...]
> > >
> > > According to arch(7) filtered by https://pkg-status.freebsd.org/ you've
> > > missed at least mips and mips64. Is this intentional?
> > 
> > devel/pire built fine[1] on 11.1 mips64. ONLY_FOR_ARCHS was originally
> > added by you in r265679. Can you recheck on powerpc* and sparc64?
> 
> I'll try to build it on ppc32/macmini and sparc64/qemu once it finishes its
> current job and report back.

Actually, it has some signs of endian-awareness, e.g. in `pire/defs.h' it
checks for PIRE_WORDS_BIGENDIAN define; but 1) post-configure, endianness
macro is WORDS_BIGENDIAN, not PIRE_WORDS_BIGENDIAN; 2) even with patched
`pire/defs.h', tests still fail.

Technically it builds under both powerpc and sparc64 without any patches,
but I didn't verify whether it really works there (on big-endian) or not.

./danfe