svn commit: r448998 - head/net-mgmt/tcpreplay

[Emanuel Haupt]

Dan Langille <dan at langille.org> wrote:
> > On Aug 30, 2017, at 4:36 PM, Jan Beich <jbeich at FreeBSD.org> wrote:
> > 
> > Dan Langille <dvl at FreeBSD.org> writes:
> > 
> >> Author: dvl
> >> Date: Wed Aug 30 19:32:00 2017
> >> New Revision: 448998
> >> URL: https://svnweb.freebsd.org/changeset/ports/448998
> >> 
> >> Log:
> >>  Add base/port options for libpcap
> > [...]
> >> +OPTIONS_DEFINE=	LIBPCAP_BASE LIBPCAP_PORTS
> > [...]
> >> +OPTIONS_SINGLE=	SG1
> >> +OPTIONS_SINGLE=	LIBPCAP_BASE LIBPCAP_PORTS
> > 
> > _SINGLE declares a group of options, not the option themselves.
> > When _SINGLE is overloaded by _DEFINE the option is no longer
> > exclusive.
> > 
> > Did you forget to adjust Porter's Handbook example?
> 
> So it seems, thank you.
> 
> > OPTIONS_SINGLE=	LIBPCAP
> > OPTIONS_SINGLE_LIBPCAP=	LIBPCAP_BASE LIBPCAP_PORTS
> > 
> >> +OPTIONS_DEFAULT=	LIBPCAP_BASE
> > 
> > Doesn't work if net/libpcap is installed as a dependency by another
> > (unrelated) port.
> 
> What do you mean by doesn't work?
> 
> tcpreplay will work. It will use the lib in base, and ignore the lib
> provided by net/libpcap
> 
> Do I misunderstand?
> 
> > +LIBPCAP_PORTS_BUILD_DEPENDS=
> > ${LOCALBASE}/lib/libpcap.a:net/libpcap
> >> +LIBPCAP_PORTS_LIB_DEPENDS=	libpcap.so:net/libpcap
> > 
> > Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS.
> 
> I don't understand the .1 - did i miss another handbook item?

I'm committing a patch shortly to address those issues.