svn commit: r448928 - in head/graphics: . drm-next-kmod

[Jung-uk Kim]

On 08/29/2017 16:50, Jan Beich wrote:
> Jung-uk Kim <jkim at FreeBSD.org> writes:
> 
>> On 08/29/2017 13:13, Jan Beich wrote:
>>
>>> Johannes M Dieterich <jmd at FreeBSD.org> writes:
>>>
>>>> Author: jmd
>>>> Date: Tue Aug 29 16:32:19 2017
>>>> New Revision: 448928
>>>> URL: https://svnweb.freebsd.org/changeset/ports/448928
>>>>
>>>> Log:
>>>>   New port: graphics/drm-next-kmod.
>>> [...]
>>>> +USES=		kmod uidfix
>>>
>>> Fails to build if SRC_BASE != /usr/src. With SRCTOP undefined the port
>>> relies on /sys symlink existing and pointing to a real location. The
>>> latter conflicts with $SRC_BASE/etc/Makefile hardcoding "usr/src/sys".
>>>
>>> Maybe add MAKE_ENV = SRCTOP="${SRC_BASE}" to fix the following.
>>>
>>> $ make DISABLE_MAKE_JOBS=
>>> ===>  Building for drm-next-kmod-g20170825
>>> ===> drm (all)
>>> Warning: Object directory not changed from original /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/drm
>>> ===> amd (all)
>>> make[3]:
>>> "/usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd/Makefile"
>>> line 3: Cannot open /sys/conf/kern.opts.mk
>>> make[3]: Fatal errors encountered -- cannot continue
>>> make[3]: stopped in /usr/ports/graphics/drm-next-kmod/work/kms-drm-4ee5acb/amd
>>> *** Error code 1
>>
>> Also, please fix non-root build while you're at it.  Please see the
>> attached patch.
> 
> See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221915 ;)

Oh, you beat me to it. :-)

>> +MAKE_ENV+=	KMODOWN=${UID} KMODGRP=${GID}
> 
> According to bsd.own.mk when USES=uidfix is set KMOD(OWN|GRP) inherit
> uid/group from BIN(OWN|GRP). Have you tried to omit the line?

Ah, I haven't tried it.  Yes, you're right.

Thanks!

Jung-uk Kim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170829/80713c66/attachment.sig>