svn commit: r448620 - in head: devel/leatherman/files devel/llvm-devel/files sysutils/facter/files x11-wm/cde/files

[Romain Tartière]

On Wed, Aug 23, 2017 at 05:32:53PM +0200, Mathieu Arnold wrote:
> I do not really understand what this patch is trying to achieve
> 
> Baptiste and I only talked about patches, there are no patches in it.

Okay, I might be missing something basic…

$FreeBSD$ may be expanded to something that gives information about the
svn revision the file was last modified.  For this to happen, the
'svn:keywords' property should be set to something like 'FreeBSD=%H'.

At some point, it was decided that this information was useless for
patches and such lines where removed from them.  I don't really see
value here for the removal, but I agree that those keywords did not
really bring value neither, so this looks OK to me.

We have many files with "$FreeBSD$" in them and without svn:keywords
set.  There is therefore no keyword expansion in them, and I don't see
more value added by these "$FreeBSD$" strings in these files than in
patches…  Hence the proposed patch to remove them.


If these non-expanded keyword make sense for non-patches and do not make
sense for patches, please explain this to me why, because I really don't
understand the difference :-S.

Thanks!

-- 
Romain Tartière <romain at FreeBSD.org>  http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170823/2e8a83cd/attachment.sig>