svn commit: r448610 - in head/devel/leatherman: . files

[Romain Tartière]

On Wed, Aug 23, 2017 at 03:49:34PM +0200, Baptiste Daroussin wrote:
> What is wrong with make makepatch? I am not aware of patchtool.py it probably
> predate make makpatch has become acutally useful :)

I am not sure that something is actually "wrong" with it…  I usualy use
patchtool :-/

Running `make makepatch` in the current "sysutils/facter" seems to
update all patches to change dates, e.g.:

---------------------------------- 8< ----------------------------------
---- cmake/FindCPPHOCON.cmake.orig      2017-06-27 17:42:22 UTC
+--- cmake/FindCPPHOCON.cmake.orig      2017-08-16 19:04:37 UTC
---------------------------------- 8< ----------------------------------

I guess that if a file which is patched has been modified upstream
between two releases, the patch will have to be regenerated with a new
timestamp (what make makepatch does and patchtool does not)?


Another point with `make makepatch`: in the post-patch target, I alter
the patched source code.  `make makepatch` wants the combined patches to
be combined:

---------------------------------- 8< ----------------------------------
-+        return "%%PREFIX%%/etc/facter/facter.conf";
++        return "/usr/local/etc/facter/facter.conf";
---------------------------------- 8< ----------------------------------

https://svnweb.freebsd.org/ports/head/sysutils/facter/files/patch-lib_src_util_config_posix_config.cc?view=markup&pathrev=448483
https://svnweb.freebsd.org/ports/head/sysutils/facter/Makefile?revision=448483&view=markup&pathrev=448483#l36

Is it possible to avoid this?

> Anyway the issue is why adding keywords on top of patches in files, it is
> inconsistent with the rest of the ports tree

I'll work on fixing this and avoid it to happen again…

Thanks

-- 
Romain Tartière <romain at FreeBSD.org>  http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170823/0dc5b8a0/attachment.sig>