svn commit: r422218 - head/net-im/corebird

[Carlos J. Puga Medina]

On Thu, 2016-09-15 at 20:56 +0200, Olivier Duchateau wrote:
> On Thu, 15 Sep 2016 17:56:57 +0000 (UTC)
> "Carlos J. Puga Medina" <cpm at FreeBSD.org> wrote:
> 
> > 
> > Author: cpm
> > Date: Thu Sep 15 17:56:56 2016
> > New Revision: 422218
> > URL: https://svnweb.freebsd.org/changeset/ports/422218
> > 
> > Log:
> >   - Update corebird to 1.3.1 release
> >   - Add GSTREAMER_USE=hls dependency
> >   - Line up options block
> >   - Silence all three explicitly called commands
> Why hide these commands?
> 
> Your mentor (here, Dmitry) argues for the opposite (see his recent
> changes with revision r421635, I know it's for CMake, Ninja,
> autotools and so on) and he approves this.
> 
> I don't understand his behaviour.
> 

I'm not completely sure, but hide such commands would be rather
consider as a cosmetic fix.

If Dmitry sees this comment, he may shed some light here :)

> > 
> >   
> >   Changelog:
> >     https://github.com/baedert/corebird/releases/tag/1.3.1
> >   
> >   Reviewed by:	amdmi3 (mentor)
> >   Approved by:	amdmi3 (mentor)
> >   Differential Revision:	D7800
> > 
> > Modified:
> >   head/net-im/corebird/Makefile
> >   head/net-im/corebird/distinfo
> > 
> > Modified: head/net-im/corebird/Makefile
> > ===================================================================
> > ===========
> > --- head/net-im/corebird/Makefile	Thu Sep 15 17:30:23 2016	
> > (r422217)
> > +++ head/net-im/corebird/Makefile	Thu Sep 15 17:56:56 2016	
> > (r422218)
> > @@ -2,7 +2,7 @@
> >  # $FreeBSD$
> >  
> >  PORTNAME=	corebird
> > -PORTVERSION=	1.3
> > +PORTVERSION=	1.3.1
> >  CATEGORIES=	net-im
> >  
> >  MAINTAINER=	cpm at FreeBSD.org
> > @@ -26,23 +26,23 @@ GNU_CONFIGURE=	yes
> >  USE_GNOME=	atk cairo gdkpixbuf2 glib20 gtk30 intltool
> > libxml2 pango
> >  INSTALLS_ICONS=	yes
> >  
> > -OPTIONS_DEFINE=		GSTREAMER
> > -OPTIONS_DEFAULT=	GSTREAMER
> > -GSTREAMER_USE=	gstreamer1=yes,bad,good,gtksink,libav,x,xima
> > gesrc
> > +OPTIONS_DEFINE=			GSTREAMER
> > +OPTIONS_DEFAULT=		GSTREAMER
> > +GSTREAMER_USE=			gstreamer1=yes,bad,good,gtks
> > ink,hls,libav,x,ximagesrc
> >  GSTREAMER_CONFIGURE_OFF=	--disable-video
> >  
> >  GLIB_SCHEMAS=	org.baedert.corebird.gschema.xml
> >  
> >  post-extract:
> > -	cd ${WRKSRC}/data && ${MV} org.baedert.corebird.desktop.in
> > \
> > -		corebird.desktop.in
> > +	@(cd ${WRKSRC}/data && ${MV}
> > org.baedert.corebird.desktop.in \
> > +		corebird.desktop.in)
> >  
> >  pre-configure:
> > -	${MKDIR} ${WRKSRC}/m4
> > +	@${MKDIR} ${WRKSRC}/m4
> >  
> >  # Replace locales files in right place
> >  post-configure:
> > -	${REINPLACE_CMD} -e 's|[$$][(]DATADIRNAME[)]|share|' \
> > +	@${REINPLACE_CMD} -e 's|[$$][(]DATADIRNAME[)]|share|' \
> >  		${WRKSRC}/po/Makefile
> >  
> >  .include <bsd.port.mk>
> > 
> > Modified: head/net-im/corebird/distinfo
> > ===================================================================
> > ===========
> > --- head/net-im/corebird/distinfo	Thu Sep 15 17:30:23 2016	
> > (r422217)
> > +++ head/net-im/corebird/distinfo	Thu Sep 15 17:56:56 2016	
> > (r422218)
> > @@ -1,3 +1,3 @@
> > -TIMESTAMP = 1470087209
> > -SHA256 (baedert-corebird-1.3_GH0.tar.gz) =
> > f4f86a2e898342297c2379c25b6274598d81d8983f185d98753725552f670860
> > -SIZE (baedert-corebird-1.3_GH0.tar.gz) = 431652
> > +TIMESTAMP = 1473189673
> > +SHA256 (baedert-corebird-1.3.1_GH0.tar.gz) =
> > cbc832b9e3adab698b9b879b64e33bffd708776e08fe9f229885068193525190
> > +SIZE (baedert-corebird-1.3.1_GH0.tar.gz) = 433961
> > 
> 
-- 
Carlos Jacobo Puga Medina <cpm at FreeBSD.org>
PGP fingerprint = C60E 9497 5302 793B CC2D  BB89 A1F3 5D66 E6D0 5453
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160915/a1f5deee/attachment-0001.sig>