svn commit: r422151 - head/devel/php70-APCu

[Guido Falsi]

On 09/15/16 10:01, Mathieu Arnold wrote:
> Le 15/09/2016 à 01:29, Guido Falsi a écrit :
>> On 09/15/16 01:22, Guido Falsi wrote:
>>
>>> Meybe some cleaner way to allow php7 parts to be built on the cluster
>>> should be made available, although I don't know what that can be right now.
>>>
>> For example, would such definition be more acceptable if limited to
>> PACKAGE_BUILDING?
> 
> The problem I have with its usage directly in ports is that it is
> supposed to be a global user settable variable, saying "I want php XX"
> (using DEFAULT_VERSIONS+=php=XX in /etc/make.conf).
> 
> For this port, though, I may have over-reacted, it is named php70- and
> can only work with 7.0. Now that I have slept on it, I would say leave
> it like that, with PHP_DEFAULT set. It is the only case where setting it
> is acceptable.
> 
> For example, it is not acceptable in a pecl-foo port, because the user
> will be left to wonder why running "pkg install pecl-foo" removed his
> php 5.6 installation.
> 

For the record, I was looking at the tree and the other ports doing the
same are:

www/pecl-http
databases/php70-redis
databases/php55-redis
databases/php56-redis
devel/php70-APCu

(each setting the relevant PHP version)

The only one not respecting your reasoning(which I tend to agree with)
is www/pecl-http, which is really a php 7.0 only version, there are
ports for older versions supporting only php 5.6 and php 5.5.

While the name does not make it perfectly clear, the same reasoning
could be applied.

Thanks for keeping an eye on commits though, this is the only way to
spot real mistakes!

-- 
Guido Falsi <madpilot at FreeBSD.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 502 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160915/05940114/attachment.sig>