svn commit: r424182 - in head: Mk Mk/Uses accessibility/jovie accessibility/kaccessible accessibility/kmag accessibility/kmousetool accessibility/kmouth archivers/ark astro/kstars astro/marble audi...

[Tobias C. Berner]

Hi

The virtual categories themselves like kde-kde4, kde-frameworks (~70
ports), kde-plasma (~40 ports), kde-applications (~200 ports) make sense
themselves, as they have more ports than some non-virtual ones, and nicely
group the KDE ports some more into what upstream ships.

The only thing we do here, is doing something useful with the value of
CATEGORIES.

There is no unexpected behaviour, as the values are not overwritten.

And the magic is still enabled by USES. USES=kde:[45] enables the magic.
The change to bsd.port.mk is has no meaning unless kde:[45] is used. The
magic just peaks at CATEGORIES to decide what to do.


mfg Tobias

On 19 October 2016 at 08:12, Adam Weinberger <adamw at adamw.org> wrote:

> > On 18 Oct, 2016, at 11:22, Tobias C. Berner <tcberner at freebsd.org>
> wrote:
> >
> > Author: tcberner
> > Date: Tue Oct 18 17:22:35 2016
> > New Revision: 424182
> > URL: https://svnweb.freebsd.org/changeset/ports/424182
> >
> > Log:
> >  Introduce new extensible virtual categories for KDE
> >
> >  A lot of KDE Ports share MASTERSITES, LICENSE and so one, as they are
> >  released as a bundle upstream, however, there was not really a clean
> >  way to share this information.
> >
> >  Using these new categories, we can simplify the Makefiles for the
> diverse
> >  KDE ports.
> >  At the moment we support the virtual category
> >       * kde-kde4
> >  In the future, this will be extended to
> >       * kde-frameworks
> >       * kde-plasma
> >       * kde-applications
> >
> >  PR:                                          213406
> >  Differential Revision:       https://reviews.freebsd.org/D7645
> >  Exp-run by :                 antoine
> >  Reviewed by:                 mat, rakuco
> >  Approved by:                         portmgr (mat), rakuco (mentor)
> >
>
> I hate to be that guy, but....
>
> Are you sure that turning category into a magical setting is the best way
> to go? Category has never been magical before, and it sets a whole new
> precedent (until now, "Why aren't my distfiles showing up where I expect?"
> has never been answered with "CATEGORY").
>
> Wouldn't something like
>         USES=   kde:dist-kde4
> be a more predictable way of doing this?
>
> USES enables magic. CATEGORY sets the category. Do we really want to
> change that?
>
> # Adam
>
>
> --
> Adam Weinberger
> adamw at adamw.org
> http://www.adamw.org
>
>