svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files

[Mathieu Arnold]

Le 17/10/2016 à 18:26, John Marino a écrit :
> On 10/17/2016 11:20, Mathieu Arnold wrote:
>> Le 17/10/2016 à 17:55, John Marino a écrit :
>>> On 10/17/2016 10:52, Mathieu Arnold wrote:
>>>> Le 17/10/2016 à 17:15, John Marino a écrit :
>>>>>   Apparently USES=pathfix and USES=autoreconf can't be used
>>>>> together, so
>>>>>   the pkgconfig directory is now passed via MAKE_ARGS
>>>>
>>>> That is mostly not true. What usage makes it so that they do not work
>>>> together ?
>>>
>>> The results suggest that "${WRKSRC}/configure" was modified, then
>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the
>>> pkgconfig path change was reverted.
>>>
>>> That's why I had to replace pathfix with MAKE_ARGS.
>>
>> No, USES=pathfix changes the content of PATHFIX_MAKEFILEIN, which by
>> default, is Makefile.in. It won't change configure unless you set
>> PATHFIX_MAKEFILEIN=configure.
>>
>
> Well, I didn't add MAKE_ARGS for fun.
> After adding USES+=autoreconf, the build broke.  pathfix was still in
> place.  You can reproduce by adding pathfix back before "python" and
> commenting out the new MAKE_ARGS line I added and check with
> "check-plist"   It's easy to confirm.

I never said your fix did not work or was not right, I said USES=pathfix
won't touch configure.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20161017/a3171638/attachment.sig>