svn commit: r422981 - in head/dns: bind9-devel bind910 bind911 bind99

[John Marino]

On 10/4/2016 09:13, Mathieu Arnold wrote:
> Le 04/10/2016 à 16:04, John Marino a écrit :
>> On 10/4/2016 09:01, Mathieu Arnold wrote:
>>> Le 04/10/2016 à 15:45, John Marino a écrit :
>>>> On 9/30/2016 07:44, Mathieu Arnold wrote:
>>>>> Author: mat
>>>>> Date: Fri Sep 30 12:44:27 2016
>>>>> New Revision: 422981
>>>>> URL: https://svnweb.freebsd.org/changeset/ports/422981
>>>>>
>>>>> Log:
>>>>>   So, on 9, it is failing to build it with jobs.
>>>>>
>>>>>   It builds .a before all the .o that are supposed to go in the .a are
>>>>>   built.  Imagine what happens after that...
>>>>>
>>>>>   Reported by:    Craig Leres
>>>>>   Sponsored by:    Absolight
>>>>>
>>>>> Modified:
>>>>>   head/dns/bind9-devel/Makefile   (contents, props changed)
>>>>>   head/dns/bind910/Makefile   (contents, props changed)
>>>>>   head/dns/bind911/Makefile   (contents, props changed)
>>>>>   head/dns/bind99/Makefile   (contents, props changed)
>>>>>
>>>>> Modified: head/dns/bind9-devel/Makefile
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- head/dns/bind9-devel/Makefile    Fri Sep 30 11:40:44 2016
>>>>> (r422980)
>>>>> +++ head/dns/bind9-devel/Makefile    Fri Sep 30 12:44:27 2016
>>>>> (r422981)
>>>>> @@ -238,6 +238,10 @@ PORTDOCS=    *
>>>>>
>>>>>  .include <bsd.port.pre.mk>
>>>>>
>>>>> +.if ${OSVERSION} <= 1000000
>>>>> +MAKE_JOBS_UNSAFE=    yes
>>>>> +.endif
>>>>> +
>>>>>  .if ( ${PORT_OPTIONS:MGOST} || ${PORT_OPTIONS:MGOST_ASN1} ) &&
>>>>> ${SSL_DEFAULT} == base
>>>>>  BROKEN=    OpenSSL from the base system does not support GOST, add \
>>>>>      DEFAULT_VERSIONS+=ssl=openssl to your /etc/make.conf and rebuild
>>>>> everything \
>>>>>
>>>>> Modified: head/dns/bind910/Makefile
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- head/dns/bind910/Makefile    Fri Sep 30 11:40:44 2016    (r422980)
>>>>> +++ head/dns/bind910/Makefile    Fri Sep 30 12:44:27 2016    (r422981)
>>>>> @@ -225,6 +225,10 @@ PORTDOCS=    *
>>>>>
>>>>>  .include <bsd.port.pre.mk>
>>>>>
>>>>> +.if ${OSVERSION} <= 1000000
>>>>> +MAKE_JOBS_UNSAFE=    yes
>>>>> +.endif
>>>>> +
>>>>>  .if ( ${PORT_OPTIONS:MGOST} || ${PORT_OPTIONS:MGOST_ASN1} ) &&
>>>>> ${SSL_DEFAULT} == base
>>>>>  BROKEN=    OpenSSL from the base system does not support GOST, add \
>>>>>      DEFAULT_VERSIONS+=ssl=openssl to your /etc/make.conf and rebuild
>>>>> everything \
>>>>>
>>>>> Modified: head/dns/bind911/Makefile
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- head/dns/bind911/Makefile    Fri Sep 30 11:40:44 2016    (r422980)
>>>>> +++ head/dns/bind911/Makefile    Fri Sep 30 12:44:27 2016    (r422981)
>>>>> @@ -236,6 +236,10 @@ PORTDOCS=    *
>>>>>
>>>>>  .include <bsd.port.pre.mk>
>>>>>
>>>>> +.if ${OSVERSION} <= 1000000
>>>>> +MAKE_JOBS_UNSAFE=    yes
>>>>> +.endif
>>>>> +
>>>>>  .if ( ${PORT_OPTIONS:MGOST} || ${PORT_OPTIONS:MGOST_ASN1} ) &&
>>>>> ${SSL_DEFAULT} == base
>>>>>  BROKEN=    OpenSSL from the base system does not support GOST, add \
>>>>>      DEFAULT_VERSIONS+=ssl=openssl to your /etc/make.conf and rebuild
>>>>> everything \
>>>>>
>>>>> Modified: head/dns/bind99/Makefile
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- head/dns/bind99/Makefile    Fri Sep 30 11:40:44 2016    (r422980)
>>>>> +++ head/dns/bind99/Makefile    Fri Sep 30 12:44:27 2016    (r422981)
>>>>> @@ -190,6 +190,10 @@ PORTDOCS=    *
>>>>>
>>>>>  .include <bsd.port.pre.mk>
>>>>>
>>>>> +.if ${OSVERSION} <= 1000000
>>>>> +MAKE_JOBS_UNSAFE=    yes
>>>>> +.endif
>>>>> +
>>>>>  .if ( ${PORT_OPTIONS:MGOST} ) && ${SSL_DEFAULT} == base
>>>>>  BROKEN=    OpenSSL from the base system does not support GOST, add \
>>>>>      DEFAULT_VERSIONS+=ssl=openssl to your /etc/make.conf and rebuild
>>>>> everything \
>>>>>
>>>>
>>>> It's not specific to FreeBSD 9:
>>>> --- rndc-confgen ---
>>>> /usr/libexec/binutils225/elf/ld.gold: error: unix/os.o: file is empty
>>>> keygen.o:keygen.c:function write_key_file: error: undefined reference
>>>> to 'set_user'
>>>>
>>>> Would you consider returning this to unconditional unsafe as it was
>>>> before?
>>>
>>> What FreeBSD version is this ? I have tried quite a few times on 10/11
>>> before declaring that they were safe, whereas on 9 it was always
>>> failing.
>>
>> It's not, it's DragonFly.
>> The opsys isn't relevant. It just means the tests you did weren't
>> sufficient to determine jobs safety, which is a pregnancy test (it
>> either is or is not; this obviously isn't)
>>
>> We build under a very heavy load which flushes out marginally unsafe
>> ports.
>
> Ok, so make(1) from dragonfly has the same bug make(1) from FreeBSD 9
> has, feel free to fix it in dragonfly's port tree.

master has bmake 20160818 on it (for last 5 weeks)
Release 4.6 has bmake 20141111.
Do you know if make bug only applies to master?

Thanks,
John




---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus