svn commit: r426826 - in head/net: ntp ntp-devel

[Cy Schubert]

In message <d9e2fea2-0d40-7ee5-ef1f-a520918188cd at ee.lbl.gov>, Craig Leres 
write
s:
> On 11/23/16 12:35, Cy Schubert wrote:
> > That was fixed by r426923. You will need to update your ports tree.
> 
> Sorry; I missed that.
> 
> > My two poudriere builders (running -CURRENT) had no issues with r426923.
> > 
> > I don't have good Internet access (I'm semi-AFK until Friday and fully AFK 
> > Friday and Saturday). I won't be back until Sunday. I defer to delphij to 
> > address any other issues until I return.
> 
> Unfortunately adding a build depend for devel/autogen doesn't solve the
> stage failure. It does let it get further:
> 
>     Making install in tests
>     /usr/bin/make  install-am
>     TEMPDIR=`pwd` && export TEMPDIR && cd . &&  ../scripts/build/genver
> m4/version.m4
>     CDPATH="${ZSH_VERSION+.}:" && cd . && aclocal-1.15 -I m4 -I
> libevent/m4 -I libopts/m4
>     aclocal-1.15: not found
>     *** [./aclocal.m4] Error code 127
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9/sntp.
>     *** [install-recursive] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9/sntp.
>     *** [install] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9/sntp.
>     *** [install-recursive] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9.
>     *** [install] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9.
>     *** [do-install] Error code 1
> 
>     Stop in /usr/ports/net/ntp.
> 
> Adding a BUILD_DEPENDS for aclocal:devel/automake takes it off into the
> weeds:
> 
>     Making install in tests
>     /usr/bin/make  install-am
>     TEMPDIR=`pwd` && export TEMPDIR && cd . &&  ../scripts/build/genver
> m4/version.m4
>     cc -DHAVE_CONFIG_H -I.  -I./../include  -I./../lib/isc/include
> -I./../lib/isc/pthreads/include  -I./../lib/isc/unix/include -I./libopts
> -I/usr/local/include    -isys
> tem /usr/local/include -ffunction-sections -fdata-sections -Wall
> -Wcast-align -Wcast-qual -Wmissing-prototypes -Wpointer-arith -Wshadow
> -Winit-self -Wstrict-overflow   -W
> no-strict-prototypes -O2 -pipe -fstack-protector -isystem
> /usr/local/include -fno-strict-aliasing -MT crypto.o -MD -MP -MF
> .deps/crypto.Tpo -c -o crypto.o crypto.c
>     In file included from crypto.h:13,
>                      from crypto.c:2:
>     sntp-opts.h:59:3: error: #error option template version mismatches
> autoopts/options.h header
>     In file included from crypto.h:13,
>                      from crypto.c:2:
>     sntp-opts.h:60: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'Me'
>     sntp-opts.h:90: warning: data definition has no type or storage class
>     sntp-opts.h:90: warning: type defaults to 'int' in declaration of
> 'teOptIndex'
>     *** [crypto.o] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9/sntp.
>     *** [install-recursive] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9/sntp.
>     *** [install] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9/sntp.
>     *** [install-recursive] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9.
>     *** [install] Error code 1
> 
>     Stop in /wrkdirs/usr/ports/net/ntp/work/ntp-4.2.8p9.
>     *** [do-install] Error code 1
> 
>     Stop in /usr/ports/net/ntp.
> 
> I don't understand why autogen/automake come into play for 9.3 but not
> 10.3. Meanwhile turns out 4.2.8p9 also has vulnerabilities:
> 
> 
> http://support.ntp.org/bin/view/Main/SecurityNotice#November_2016_ntp_4_2_8p9
> _NTP_Se
> 
> So maybe it's best to wait for p10 and hope that it builds and packages
> cleanly on 9.3?

Turn autoreconf on. I'm considering committing the following when I get 
back.

Index: Makefile
===================================================================
--- Makefile	(revision 426974)
+++ Makefile	(working copy)
@@ -22,6 +22,10 @@
 USES=		cpe pathfix shebangfix libedit libtool localbase:ldflags \
 		pkgconfig ssl
 
+.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000
+USES+=		autoreconf
+.endif
+
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--enable-leap-smear
 

-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.