svn commit: r426759 - in head/databases/xapian-core: . files

[Mathieu Arnold]

Le 22/11/2016 à 11:12, Raphael Kubo da Costa a écrit :
> Mathieu Arnold <mat at FreeBSD.org> writes:
>
>> Le 21/11/2016 à 22:26, Raphael Kubo da Costa a écrit :
>>
>>>   SOCK_CLOEXEC was introduced in FreeBSD 10, so define it to 0 on FreeBSD 9 (the
>>>   code already handles this case). Xapian 1.4 has a safesyssocket.h that does the
>>>   same thing.
>> But FreeBSD 10 is not 1000000. In that case, according to
>> sys/sys/socket.h's log, it was added in r248534, the closest version is
>> 1000031.
> I tried looking for a specific entry mentioning SOCK_CLOEXEC in the
> porter's handbook and decided to go with 1000000 after not finding
> anything.
>
> I'm fine with adjusting the check, but given 1000031 predates even the
> branching of FreeBSD 10 and the minimum 10.x version we currently
> support is 10.1, does it make sense to do that?

1000000 is wrong because SOCK_CLOEXEC was added between 1000030 and
1000031. So the right OSVERSION to use is 1000031.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20161122/58d3ed6a/attachment.sig>