svn commit: r426722 - in head/lang: . pocl pocl/files

Adam Weinberger adamw at adamw.org
Mon Nov 21 22:43:25 UTC 2016


> On 21 Nov, 2016, at 15:04, Koop Mast <kwm at FreeBSD.org> wrote:
> 
> On Mon, 2016-11-21 at 19:33 +0100, Mathieu Arnold wrote:
>> Le 21/11/2016 à 15:36, Koop Mast a écrit :
>>> 
>>> +do-test:
>>> +	cd ${WRKSRC} && ${GMAKE} check
>> NEVER use GMAKE, it is always called MAKE_CMD. Also, all this should
>> be
>> written as:
>> 
>> TEST_TARGET=    check
> 
> I thik I looked up MAKE_CMD once but I don't use this that often so I
> probably forgot about that. I will try to keep it in mind for the next
> time. I didn't know about TEST_TARGET existence.
> 
> These problems have been corrected, thanks for your comments!

(Mat is right here, TEST_TARGET is the way to go here).

Just FTR, personally I’m really into ${DO_MAKE_BUILD}, which sets up all the right environment and arguments and uses the proper MAKE_CMD.

	${DO_MAKE_BUILD} check

DO_MAKE_BUILD is one of the most underrated macros in the ports system!

# Adam


—
Adam Weinberger
adamw at adamw.org
http://www.adamw.org



More information about the svn-ports-all mailing list