svn commit: r426722 - in head/lang: . pocl pocl/files

Mathieu Arnold mat at FreeBSD.org
Mon Nov 21 18:33:41 UTC 2016


Le 21/11/2016 à 15:36, Koop Mast a écrit :
> +#USES=		autoreconf gmake localbase pathfix pkgconfig libtool
> +USES=		gmake localbase ncurses pathfix pkgconfig libtool:keepla
> +
> +#CONFIGURE_ARGS+=	--enable-pedantic

Commented out lines in Makefiles makes you wonder about the quality of
the submission, wether it is a work in progress, or a final patch

> +do-test:
> +	cd ${WRKSRC} && ${GMAKE} check

NEVER use GMAKE, it is always called MAKE_CMD. Also, all this should be
written as:

TEST_TARGET=    check


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20161121/20ccb54e/attachment.sig>


More information about the svn-ports-all mailing list