svn commit: r411957 - in head/multimedia: . syncplay syncplay/files

[Jan Beich]

Jan Beich <jbeich at vfemail.net> writes:

> Kurt Jaeger <pi at FreeBSD.org> writes:
>
>> +.if !empty(PORT_OPTIONS:MCLIENT) && !empty(PORT_OPTIONS:MSERVER)
>> +INSTALL_TARGET=	install
>> +.endif
>> +
>> +.include <bsd.port.mk>
>
> PORT_OPTIONS is always empty before <bsd.port.options.mk> is included
> which this port doesn't attempt. If you want to keep .if conditionals
> out try the untested patch below.
>
> Index: multimedia/syncplay/Makefile
> ===================================================================
> --- multimedia/syncplay/Makefile	(revision 411966)
> +++ multimedia/syncplay/Makefile	(working copy)
> @@ -26,6 +26,7 @@ OPTIONS_MULTI_MODES=	CLIENT SERVER
>  VLC_DESC=	Support for VLC media player
>  
>  MAKEFILE=	GNUmakefile
> +INSTALL_TARGET=	# empty

Actually, the way INSTALL_TARGET is defined via ?= in bsd.port.mk this
line is not even needed. OPTIONS_MULTI guarantees either CLIENT or
SERVER overrides default value.

>  
>  GUI_RUN_DEPENDS=	pyside-py2?>=1.1.2:devel/pyside
>  
> @@ -34,8 +35,4 @@ VLC_MAKE_ARGS_OFF=	VLC_SUPPORT=false
>  CLIENT_INSTALL_TARGET=	install-client
>  SERVER_INSTALL_TARGET=	install-server
>  
> -.if !empty(PORT_OPTIONS:MCLIENT) && !empty(PORT_OPTIONS:MSERVER)
> -INSTALL_TARGET=	install
> -.endif
> -
>  .include <bsd.port.mk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160326/c48c9f98/attachment.sig>