svn commit: r410937 - head/graphics/hugin-2016

[Greg 'groggy' Lehey]

On Sunday, 13 March 2016 at  1:47:22 +0100, Mathieu Arnold wrote:
> +--On 13 mars 2016 10:36:54 +1100 Greg 'groggy' Lehey <grog at FreeBSD.org>
> wrote:
>> On Saturday, 12 March 2016 at 23:44:26 +0100, Mathieu Arnold wrote:
>>> Hi,
>>>
>>> +--On 12 mars 2016 22:36:11 +0000 Greg Lehey <grog at FreeBSD.org> wrote:
>>>> Author: grog (src committer)
>>>> Date: Sat Mar 12 22:36:11 2016
>>>> New Revision: 410937
>>>> URL: https://svnweb.freebsd.org/changeset/ports/410937
>>>>
>>>> Log:
>>>>   Upgrade to 2016.0.0 RC2.
>>>>   Remove repetitive PKGNAMESUFFIX.
>>>
>>> It looks like it was not reviewed by a ports committer, which explains
>>> the mistakes, could you please get all your following ports commits
>>> reviewed by a ports committer ?
>>
>> I am a ports committer, as my ex-mentors edwin@ and itetcu@ should
>> confirm, though it seems that the appropriate lists haven't been
>> updated.  I'm also MAINTAINER for this port.  And I see no mistakes.
>> If you see any, it would have been helpful for you to explain, not to
>> revert without discussion.
>>
>> What's your problem?  I see that you committed this change originally
>> port without consulting me, assigning me a pointy hat (which I find
>> somewhat offensive), with an inappropriate commit message, and
>> presumably without testing.  The result is a package called
>> hugin-2016-2016.0.0.r1.  Reverting your commit gave a more logical
>> hugin-2016.0.0.r1.
>>
>> I also see that, rather than discussing this matter with me first, you
>> reverted my commit.  That's the beginning of a commit war.  I consider
>> your behaviour impolite.  Please back it out.
>
> Well, I am sorry if I offended you.

Thanks.  Apology accepted.  But of course a bit of contact in advance
would have been instructive.

> According to the access file, your ports commit bit was take in for
> safe keeping in 2008, seems nobody put you back there when you got
> back in 2013.  Thus my confusion.

Yes, as I said, it seems that there was some missed update there.
It's still like that.  How do I get the list updated?

> There already is a port that has "hugin" as PKGBASE, it is
> graphcis/hugin.  And it is forbidden to have two ports with the same
> PKGBASE.  I can refer you to the "PORTNAME And PORTREVISION" section
> of the Porter's Handbook:
> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html

I had already read that, and I agree that hugin-2016 sounds good.  But
after your change, the name was hugin-2016-2016.0.0.r1, which looks
unnecessarily repetitive.  I've been trying to think of a good
alternative name, but it escapes me.  In the meantime the port has
gone away again (as advertised), so the immediate problem has too.  Do
you have a suggestion for an alternative?  hugin-devel again, maybe?

Greg
--
Sent from my desktop computer.
Finger grog at FreeBSD.org for PGP public key.
See complete headers for address and phone numbers.
This message is digitally signed.  If your Microsoft MUA reports
problems, please read http://tinyurl.com/broken-mua
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160322/2f89d9d2/attachment.sig>