svn commit: r411399 - head/audio/fplib/files

Raphael Kubo da Costa rakuco at FreeBSD.org
Sat Mar 19 14:18:41 UTC 2016


Author: rakuco
Date: Sat Mar 19 14:18:40 2016
New Revision: 411399
URL: https://svnweb.freebsd.org/changeset/ports/411399

Log:
  Add a patch to explicitly link against libfplib.so.
  
  What the port was doing was never right, but the upcoming CMake 3.5.0 makes the
  build failures happen more often.
  
  Using target_link_libraries() with a name like fplib will just pass -lfplib to
  the linker instead of declaring a dependency between the lastfm-fpclient and
  fplib_shared targets and parallel builds may break.
  
  PR:		208033

Added:
  head/audio/fplib/files/
  head/audio/fplib/files/patch-CMakeLists.txt   (contents, props changed)

Added: head/audio/fplib/files/patch-CMakeLists.txt
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/fplib/files/patch-CMakeLists.txt	Sat Mar 19 14:18:40 2016	(r411399)
@@ -0,0 +1,15 @@
+Link against an actual target name, not the generated library name.
+
+If we link against the latter, there is no dependency between lastfm-fpclient
+and fplib, which can break parallel builds starting with CMake 3.5.0.
+--- CMakeLists.txt.orig	2016-03-16 09:53:03 UTC
++++ CMakeLists.txt
+@@ -139,7 +139,7 @@ ADD_EXECUTABLE(lastfm-fpclient
+ 
+ # Link the executable
+ TARGET_LINK_LIBRARIES(lastfm-fpclient
+-   fplib
++   fplib_shared
+    fftw3f
+    mad
+    tag


More information about the svn-ports-all mailing list