svn commit: r410453 - in head/math/fityk: . files

[Pietro Cerutti]

On 2016-03-08 14:12, Mathieu Arnold wrote:
> +--On 8 mars 2016 16:55:35 +0800 wenheping <wenheping2000 at hotmail.com>
> wrote:
> |> Date: Tue, 8 Mar 2016 08:41:19 +0000
> |> From: danfe at FreeBSD.org
> |> To: wenheping2000 at hotmail.com
> |> CC: ports-committers at freebsd.org; svn-ports-all at freebsd.org;
> |> svn-ports-head at freebsd.org Subject: Re: svn commit: r410453 - in
> |> head/math/fityk: . files
> |>
> |> On Tue, Mar 08, 2016 at 04:23:53PM +0800, wenheping wrote:
> |> > On Tue, 8 Mar 2016 08:10:10 +0000, danfe at FreeBSD.org wrote:
> |> > > On Tue, Mar 08, 2016 at 09:22:54AM +0800, wenheping wrote:
> |> > > > I did not find 'not mute installation" is wrong in Porter's
> |> > > > Handbook.
> |> > >
> |> > > It might not be articulated loud enough, but it's pretty obvious
> |> > > once you think about it: muted commands won't appear in the 
> build
> |> > > log, which makes it harder to debug and fix any issues.
> |> > >
> |> > > mkdir's are often muted because they do not have the same "debug
> |> > > value" as installation commands, but all 
> cp/COPYTREE_SHARE/ln/etc.
> |> > > commands should not be muted.  This is pretty common knowledge 
> in
> |> > > our community, I find it strange that you've never heard of it.
> |> >
> |> > To me mkdir has the same debug-value as cp
> |>
> |> That's OK, you might mute or not mute mkdir's at your own 
> discretion.
> |>
> |> > and I judge the "common knowledge in our community" by Porter's
> |> > Handbook or portlint.
> |>
> |> Truth is that most valuable pieces of wisdom are scattered across
> |> maillist discussions and stuff (FWIW, portlint(1) does warn about 
> muted
> |> INSTALL_foo
> |
> | I hope "most valuable pieces of wisdom" should go into Handbook or
> | portlint, but not only exists in maillist.
> 
> They go there.
> 
> All the examples of
> https://www.freebsd.org/doc/en/books/porters-handbook/install.html show 
> the
> commands as *not* being silenced.  I'll have a looksie around and add a
> note about it.

Where "commands" is both INSTALL (and similar) and MKDIR commands, as I 
can see.

On 2016-03-08 14:12, Mathieu Arnold wrote:
> +--On 8 mars 2016 16:55:35 +0800 wenheping <wenheping2000 at hotmail.com>
> wrote:
> |> Date: Tue, 8 Mar 2016 08:41:19 +0000
> |> From: danfe at FreeBSD.org
> |> >
> |> > To me mkdir has the same debug-value as cp
> |>
> |> That's OK, you might mute or not mute mkdir's at your own 
> discretion.

So, danfe@, would you mind explaining to me on which basis muting MKDIRs 
is "at one's discretion" while muting INSTALLs is "actually wrong"?

Given the evidence pointed at by mat@, either both muting MKDIR and 
INSTALL commands is at one's discretion, or neither is.


-- 
Pietro Cerutti
gahr at gahr.ch

PGP Public Key:
http://gahr.ch/pgp