svn commit: r418889 - in head/deskutils: . copyq

Alexey Dokuchaev danfe at FreeBSD.org
Fri Jul 22 04:46:58 UTC 2016


On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote:
> New Revision: 418889
> URL: https://svnweb.freebsd.org/changeset/ports/418889
> 
> Log:
>   CopyQ is advanced clipboard manager with editing and scripting features.
>   
>   WWW: https://github.com/hluk/CopyQ
> 
> [...]
> +USE_XORG+=	x11 xfixes xtst

What's the reason for += here?

> +USE_QT5=        core gui network svg multimedia imageformats \

Spaces were used in this line instead of proper tab.

> +USE_GL+=	gl

Bogus += again.

> +USES=           qmake

Spaces again; also it's better to place more generic USES *before* specific
USE_FOO knobs.

> +PLIST_FILES=	bin/copyq

PLIST-related knobs should be among the last ones (after USE* knobs, but
before OPTIONS* knobs).

> +do-install:
> +	${INSTALL_PROGRAM} ${WRKSRC}/copyq ${STAGEDIR}${PREFIX}/bin/copyq

Last component of destination is redundant (${STAGEDIR}${PREFIX}/bin would
be enough).

./danfe


More information about the svn-ports-all mailing list