svn commit: r418513 - in head/devel: . dwarves dwarves/files

Alexey Dokuchaev danfe at FreeBSD.org
Fri Jul 15 05:19:31 UTC 2016


On Thu, Jul 14, 2016 at 05:31:46AM +0000, Conrad E. Meyer wrote:
> New Revision: 418513
> URL: https://svnweb.freebsd.org/changeset/ports/418513
> 
> Log:
>   New port: devel/dwarves
> 
> [...]
> +MAINTAINER=	cem at FreeBSD.org
> +COMMENT=	Debugging Information Manipulation Tools

COMMENT is not a formal title and thus only the first word should be
capitalized in this case.

> +LICENSE=	GPLv2
> +LICENSE_FILE_GPLv2=	$(WRKSRC)/COPYING

Just `LICENSE_FILE' would be sufficient.  Also, style bug: we use curly
braces in ports' makefiles, not round ones (also below).

> +#CMAKE_VERBOSE=	1

[Comment removed in r418516.]  CMAKE_VERBOSE is set for unattended/package
builds in `Mk/Uses/cmake.mk', so it can be removed from here, as individual
users might have their own preference when building ports by themselves.

> +post-patch:
> +	@${CP} -a \
> +	    $(LOCALBASE)/share/gnulib/lib/gettext.h \
> +	    $(LOCALBASE)/share/gnulib/lib/obstack.c \
> +	    $(LOCALBASE)/share/gnulib/lib/obstack.h \

Bogus brace style again.

./danfe


More information about the svn-ports-all mailing list