svn commit: r418510 - head/devel/elfutils
Conrad Meyer
cem at freebsd.org
Thu Jul 14 15:09:34 UTC 2016
On Thu, Jul 14, 2016 at 1:46 AM, Baptiste Daroussin <bapt at freebsd.org> wrote:
> Which is exactly why non ports committers are not supposed to commit in the ports
> tree without a ports committer review/approval.
Sorry. I'm doing my best with the porter's handbook, just like anyone else.
> At least at quick glance there is this:
> - post-patch expects gnulib to already be installed but gnulib is a build
> dependency and not a patch dependency so not installed at the momemt you
> needed it
Why have a PATCH_DEPENDS distinct from BUILD_DEPENDS?
> - automake is not supposed to be run like this
The port doesn't need a full autoreconf, just automake. It is
intended to work in isolation to configure.ac/configure.in. The
porter's handbook did not seem to provide any better direction here.
> https://people.freebsd.org/~bapt/elfutils.diff
>
> Should fix those 2 issues
Please go ahead and commit.
Thanks,
Conrad
More information about the svn-ports-all
mailing list