svn commit: r418247 - in head/devel/gps: . files
John Marino
marino at FreeBSD.org
Fri Jul 8 22:28:06 UTC 2016
Author: marino
Date: Fri Jul 8 22:28:04 2016
New Revision: 418247
URL: https://svnweb.freebsd.org/changeset/ports/418247
Log:
devel/gps: Fix compiler error highlight on FreeBSD
On DragonFly, GPS has been properly highlighting code errors during
compilation, but on FreeBSD nothing happens. Luckily Rod Kay has been
persistent in diagnosing the cause and he finally isolated it to a
too-short timeout interval for Expect calls. The timeout period was
set to 1 millisecond, the absolute shortest interval possible. While
Linux and DF could complete the function call during this time, FreeBSD
requires at least 10 milliseconds to do the same.
I'm setting the timeout to 100 milliseconds to ensure this functionality
works on FreeBSD. Rod and I can't immediately see any negative impact
to extending the timeout and we're casually pinging Adacore to understand
the orignal 1-ms value.
PR: 202317
Added:
head/devel/gps/files/patch-kernel_src_gps-kernel-timeout.adb (contents, props changed)
Modified:
head/devel/gps/Makefile
Modified: head/devel/gps/Makefile
==============================================================================
--- head/devel/gps/Makefile Fri Jul 8 21:52:45 2016 (r418246)
+++ head/devel/gps/Makefile Fri Jul 8 22:28:04 2016 (r418247)
@@ -3,6 +3,7 @@
PORTNAME= gps
PORTVERSION= 2016
+PORTREVISION= 1
CATEGORIES= devel
MASTER_SITES= http://downloads.dragonlace.net/src/
DISTNAME= gps-gpl-${PORTVERSION}-src
Added: head/devel/gps/files/patch-kernel_src_gps-kernel-timeout.adb
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/devel/gps/files/patch-kernel_src_gps-kernel-timeout.adb Fri Jul 8 22:28:04 2016 (r418247)
@@ -0,0 +1,11 @@
+--- kernel/src/gps-kernel-timeout.adb.orig 2016-05-16 09:45:57 UTC
++++ kernel/src/gps-kernel-timeout.adb
+@@ -388,7 +388,7 @@ package body GPS.Kernel.Timeout is
+ Fd := Data.D.Descriptor;
+ if Fd /= null then
+ loop
+- Expect (Fd.all, Result, Data.Expect_Regexp.all, Timeout => 1);
++ Expect (Fd.all, Result, Data.Expect_Regexp.all, Timeout => 100);
+
+ if Result /= Expect_Timeout then
+ -- Received something. Cancel timeout
More information about the svn-ports-all
mailing list