svn commit: r407331 - head/net/geoipupdate

[Alexey Dokuchaev]

On Thu, Jan 28, 2016 at 08:51:55PM -0700, Adam Weinberger wrote:
> > On 28 Jan, 2016, at 18:54, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> > On Wed, Jan 27, 2016 at 01:16:01AM +0000, Adam Weinberger wrote:
> >> New Revision: 407331
> >> URL: https://svnweb.freebsd.org/changeset/ports/407331
> >> 
> >> [...]
> >> @@ -1,4 +1,4 @@
> >> bin/geoipupdate
> >> - at sample etc/GeoIP.conf.sample
> >> + at sample etc/GeoIP.conf etc/GeoIP.conf.default
> > 
> > I think you've got it backwards, per what I read in CHANGE at 20150926 and
> > running post-install() from +MANIFEST with commands prepended with echo:
> > [...]
> 
> Oh! You're totally right. I got confused by the wording from the
> porters-handbook.
> 
> "@sample file [file]" doesn't do much to resolve ambiguity :-P

Yes, I agree that "@sample file [file]" is not the best wording.  But in
that section 7.3, there's a Note with correct and more clear example.

> I'd suggest adding, after the first paragraph of 7.6.9:
> 
> 	So,
> 		@sample etc/myapp.conf.sample
> 	and
> 		@sample etc/myapp.conf.sample etc/myapp.conf
> 	are equivalent.

Yeah, perhaps some clarification of this sort could be helpful.

./danfe