svn commit: r420924 - head/audio/gmpc-magnatune

[Mathieu Arnold]

Le 30/08/2016 à 15:25, John Marino a écrit :
> On 8/30/2016 08:05, Paweł Pękala wrote:
>> Hi John,
>>
>> On 2016-08-29 22:20 -0500, John Marino <freebsd.contact at marino.st>
>> wrote:
>>> On 8/29/2016 22:17, John Marino wrote:
>>>> On 8/26/2016 10:04, Pawel Pekala wrote:
>>>>> Author: pawel
>>>>> Date: Fri Aug 26 15:04:06 2016
>>>>> New Revision: 420924
>>>>> URL: https://svnweb.freebsd.org/changeset/ports/420924
>>>>>
>>>>> Log:
>>>>>   - Convert to USES=sqlite
>>>>>   - Convert to PLIST_FILES, only 2 items in plist
>>>>>   - Register proxy dependencies found by stage-qa
>>>>>
>>>>> Deleted:
>>>>>   head/audio/gmpc-magnatune/pkg-plist
>>>>> Modified:
>>>>>   head/audio/gmpc-magnatune/Makefile
>>>>>
>>>>> Modified: head/audio/gmpc-magnatune/Makefile
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- head/audio/gmpc-magnatune/Makefile    Fri Aug 26 14:58:33 2016
>>>>> (r420923)
>>>>> +++ head/audio/gmpc-magnatune/Makefile    Fri Aug 26 15:04:06 2016
>>>>> (r420924)
>>>>> @@ -14,13 +14,17 @@ LICENSE=    GPLv2+
>>>>>  LICENSE_FILE=    ${WRKSRC}/COPYING
>>>>>
>>>>>  LIB_DEPENDS=    libmpd.so:audio/libmpd \
>>>>> -        libsqlite3.so:databases/sqlite3
>>>>> +        libfreetype.so:print/freetype2 \
>>>>> +        libfontconfig.so:x11-fonts/fontconfig
>>>>>  BUILD_DEPENDS=    ${LOCALBASE}/libdata/pkgconfig/gmpc.pc:audio/gmpc
>>>>>  RUN_DEPENDS=    gmpc:audio/gmpc
>>>>>
>>>>> +USES=        gettext gmake libtool pkgconfig sqlite
>>>>> +USE_GNOME=    cairo gdkpixbuf2 glib20 gtk20 intltool libglade2
>>>>>  GNU_CONFIGURE=    yes
>>>>> -USE_GNOME=    intltool glib20 gtk20 libglade2
>>>>> -USES=        gettext gmake libtool pkgconfig
>>>>>  INSTALL_TARGET=    install-strip
>>>>>
>>>>> +PLIST_FILES=    lib/gmpc/plugins/magnatuneplugin.so \
>>>>> +        share/gmpc/plugins/magnatune/magnatune.png
>>>>> +
>>>>>  .include <bsd.port.mk>
>>>>>
>>>>
>>>> Pawel,
>>>> Many library dependencies were added.  That requires a PORTREVISION
>>>> bump!
>>>
>>> actually, I meant to write this about audio/gmpc but it appears
>>> audio/gmpc-magnatune had the same issue.
>>
>> Dependencies added in both ports showed up in poudriere logs so they
>> are be definition proxy. So my commits register that this packages link
>> to particular libraries, no new dependencies are added - they are
>> already pulled in by packages needed to build port.
>>
>> I do check for new dependencies by comparing poudriere vs live
>> build stage-qa outputs to find new ones, but it's not the case here.
>>
>
> I do not believe your method is valid.
> If you use pkg(8) to check the dependencies before and after a change
> and there's not difference, no bump is needed.
>
> However, you're relying on dependencies to pull in other dependencies
> to say it's equivalent.
>
> Please check with mat@, he should confirm.
> Your method will cause poudriere and other builders to skip updating
> the port because it wasn't bumped.
>
> When in doubt, please bump.  It's better to bump unnecessarily than to
> not bump when it's required.

When adding proxied dependencies, please, always bump PORTREVISION if
you are not changing PORTVERSION. The goal of this qa check is to make
sure the package really depends on what it needs. If you don't bump
PORTREVISION, no new package is built with the correct dependency list,
and it is bad.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160830/36837937/attachment.sig>