svn commit: r420828 - head/net/py-nnpy

[Chris Rees]

Hi Kevin,

You should really either expand BUILD_DEPENDS before assigning it, with := or assign BUILD_DEPENDS to RUN_DEPENDS instead.  Doing that avoids pollution from later additions such as extra USES only used for build etc.

PORTREVISION was unnecessary here too :)

Cheers,

Chris

On 25 August 2016 01:20:01 BST, Kevin Lo <kevlo at FreeBSD.org> wrote:
>Author: kevlo
>Date: Thu Aug 25 00:20:00 2016
>New Revision: 420828
>URL: https://svnweb.freebsd.org/changeset/ports/420828
>
>Log:
>  Add missing BUILD_DEPENDS.
>  
>  Spotted by:	koobs
>
>Modified:
>  head/net/py-nnpy/Makefile
>
>Modified: head/net/py-nnpy/Makefile
>==============================================================================
>--- head/net/py-nnpy/Makefile	Wed Aug 24 23:49:06 2016	(r420827)
>+++ head/net/py-nnpy/Makefile	Thu Aug 25 00:20:00 2016	(r420828)
>@@ -2,6 +2,7 @@
> 
> PORTNAME=	nnpy
> PORTVERSION=	1.2
>+PORTREVISION=	1
> CATEGORIES=	net python
> MASTER_SITES=	CHEESESHOP
> PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
>@@ -12,7 +13,8 @@ COMMENT=	cffi-based Python bindings for 
> LICENSE=	MIT
> 
> LIB_DEPENDS=	libnanomsg.so:net/nanomsg
>-RUN_DEPENDS=	${PYTHONPREFIX_SITELIBDIR}/_cffi_backend.so:devel/py-cffi
>+BUILD_DEPENDS=	${PYTHONPREFIX_SITELIBDIR}/_cffi_backend.so:devel/py-cffi
>+RUN_DEPENDS=	${BUILD_DEPENDS}
> 
> USES=		python
> USE_PYTHON=	autoplist distutils
>
>
>-- 
>This message has been scanned for viruses and
>dangerous content by MailScanner, and is
>believed to be clean.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.