svn commit: r413352 - in head/www/rt44: . files

Alexey Dokuchaev danfe at FreeBSD.org
Fri Apr 15 17:00:02 UTC 2016


On Fri, Apr 15, 2016 at 04:28:56PM +0000, Kurt Jaeger wrote:
> New Revision: 413352
> URL: https://svnweb.freebsd.org/changeset/ports/413352
> 
> Log:
>   www/rt44: re-surrect as repo-copy of rt42
>   
>   PR:		208229
>   Submitted by:	mat

PR 208229 was not submitted by mat@, please stop adding bogus attribution
to commit logs.

>  COMMENT=	RT is an industrial-grade ticketing system written in Perl

Violation of Section 5.6 of the PHB (clause #2).

> @@ -90,7 +91,7 @@ SQLITE_RUN_DEPENDS=		${SQLITE_DEPS}
>  
>  DEVELOPER_DESC=			Configure for Developers
>  DEVELOPER_RUN_DEPENDS=		${DEVELOPER_DEPS}

Wrong spelling, "developers" is not a proper noun and should not be
capitalized.

>  SMIME_DESC=			Enable Secure MIME support

Also wrong, correct version of SMIME_DESC is "Secure MIME support".

> ---- ./Makefile.in.orig	2014-05-06 17:59:04.000000000 +0100
> -+++ ./Makefile.in	2014-05-14 15:26:37.708277377 +0100
> +--- ./Makefile.in.orig	2014-05-06 17:59:04 UTC
> ++++ ./Makefile.in

That's weird: looks like patches were (re)generated by `make makepatch`,
but still contain bogus leading `./' in the filenames.

./danfe


More information about the svn-ports-all mailing list