svn commit: r412296 - head/lang/rust

[Thomas Zander]

Hi Jan,

On 31 March 2016 at 22:04, Jan Beich <jbeich at freebsd.org> wrote:

> Author: jbeich
> Log:
>   lang/rust: unblock DragonFly build

While in general I am fine with your commits and your high quality
work, I am not happy at all about the implications in this case. I
don't use DF at the moment, but now we have bits in the port very
specific to DF. This is still "FreeBSD ports" and not
"FreeBSD-and-DF-or-something-else" ports. I will not install a machine
just for the sole purpose of ensuring that rust runs on DF. It's
actually their job to do that, that's why they have specific DF
patches. But now that it is in our official tree, you have enforced a
responsibility upon me to ensure that my next commit won't break the
build on DF, and I won't be able to verify that.

>   Approved by:  portmgr "just fix it" blanket

On this I heavily disagree. The port works on all officially supported
platforms. It is not broken, so it does not need fixing. You
introduced a new feature, namely adding extra bits to support a
non-FreeBSD platform. You should have discussed this with me first.

Maybe portmgr can comment on this to make it more clear:
- Are we obliged to ensure ports are working on DF?
- Is a commit like this covered by a "just fix it" blanket? (By the
way, where is the "just fix it" blanket documented? I did not find a
recent mail and
https://wiki.freebsd.org/ports-secteam#Blanket_Approval for sure does
not cover this commit.)

Best regards
Riggs