svn commit: r397327 - head/textproc/utf8proc
Alexey Dokuchaev
danfe at FreeBSD.org
Sat Sep 19 15:23:51 UTC 2015
On Sat, Sep 19, 2015 at 03:10:48PM +0000, Alexey Dokuchaev wrote:
> On Sat, Sep 19, 2015 at 11:06:56PM +0800, wenheping wrote:
> > > Guys, please bear in mind that Kato's patches often contain unrelated
> > > changes and should always be reviewed thoroughly before applying.
> >
> > Sorry I do not agree with you this time.
> >
> > There are 5 lines in the PLIST_FILES example in Porter's Handbook, then
> > I think 6 lines is acceptable.
>
> *sigh* (I'm not even going to point out that 6 > 5); your logic could be
> OK for a new port, but things were already perfectly fine, so this change
> was totally gratuitous and uncalled for.
To elaborate further: commit log stated "Update to 1.3", that's all. Even
if you did consider making any changes unrelated to actual version upgrade,
they should've been mentioned in the log with adequate explanation why they
were necessary or desired. This was not done, and this happens very often
when Kato's PR get committed.
./danfe
More information about the svn-ports-all
mailing list