svn commit: r396826 - head/x11/metisse

[Baptiste Daroussin]

On Sun, Sep 13, 2015 at 02:30:14PM +0000, Alexey Dokuchaev wrote:
> On Sun, Sep 13, 2015 at 02:24:59PM +0000, Baptiste Daroussin wrote:
> > New Revision: 396826
> > URL: https://svnweb.freebsd.org/changeset/ports/396826
> > 
> > Log:
> >   Clean options by using options helpers
> >   Remove gtk1 option
> >   Nuke usage of HAVE_GOME.
> >   Please notice that the port is stil wrong as it still relies on the
> >   configure script to autodetect things instead of control[l]ing it
> >   depending on options.  At least it is now a bit cleaner[.]
> 
> (Fixed some typos for you)

Thanks
> 
> Thanks, but I don't see the reason for this part:
> 
> > -post-patch: .SILENT
> > +post-patch:
> >  # Catch up with new <fribidi-types.h> header name
> > -	${REINPLACE_CMD} -e 's,fribidi_types\.h,fribidi-types.h,' \
> > +	@${REINPLACE_CMD} -e 's,fribidi_types\.h,fribidi-types.h,' \
> >  		${WRKSRC}/fvwm-insitu/libs/FBidi.c
> >  # Fix desktop entries path
> > -	${REINPLACE_CMD} -E 's,^(configdir =).*,\1 ${DESKTOPDIR},' \
> > +	@${REINPLACE_CMD} -E 's,^(configdir =).*,\1 ${DESKTOPDIR},' \
> >  		${WRKSRC}/fvwm-insitu/opale/session/Makefile.in
> > -.if defined(_NOGLADEDIR)
> > -	${REINPLACE_CMD} -e 's, install-gladeDATA,,' \
> > -		${WRKSRC}/fvwm-insitu/modules/FvwmConfig/Makefile.in
> > -.endif
> > -	${REINPLACE_CMD} -e 's,return;,return 0;,' \
> > +	@${REINPLACE_CMD} -e 's,return;,return 0;,' \
> 
> What was wrong with .SILENT?  (I ask because it was originally my port.)

Absolutely nothing, just got habbit of '@' I hesitated twice before that change
and probably picked up the wrong decision or let say have added gratuicious
change.

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20150913/1ef5771d/attachment.bin>